Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flax NNX Model Surgery #4135

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Aug 21, 2024

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@8bitmp3 8bitmp3 self-assigned this Aug 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (31adb00) to head (432c4d7).
Report is 127 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4135    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        106     109     +3     
  Lines      13582   14309   +727     
======================================
- Misses     13582   14309   +727     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! Just some small nits.

docs/nnx/surgery.md Outdated Show resolved Hide resolved
docs/nnx/.ipynb_checkpoints/surgery-checkpoint.ipynb Outdated Show resolved Hide resolved
docs/nnx/surgery.md Outdated Show resolved Hide resolved
docs/nnx/surgery.md Outdated Show resolved Hide resolved
@copybara-service copybara-service bot merged commit bc594fb into google:main Sep 5, 2024
16 checks passed
@8bitmp3 8bitmp3 deleted the update-nnx-surgery branch September 25, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants