Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More testing and misc fixes on wrappers #4137

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

IvyZX
Copy link
Collaborator

@IvyZX IvyZX commented Aug 21, 2024

Doing very small fixes and adding some tests to bridge wrappers

@IvyZX IvyZX requested a review from cgarciae August 21, 2024 20:12
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (31adb00) to head (a4aa7eb).
Report is 133 commits behind head on main.

Files Patch % Lines
flax/nnx/nnx/bridge/wrappers.py 0.00% 6 Missing ⚠️
flax/nnx/nnx/variables.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main   #4137    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files        106     109     +3     
  Lines      13582   14336   +754     
======================================
- Misses     13582   14336   +754     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@copybara-service copybara-service bot merged commit 1b2cca9 into google:main Aug 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants