Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nnx] improve docs #4141

Merged
merged 1 commit into from
Aug 27, 2024
Merged

[nnx] improve docs #4141

merged 1 commit into from
Aug 27, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Aug 24, 2024 •
edited
Loading

What does this PR do?

  • Updates the landing page and first paragraph of NNX Basics to clarify what NNX is.
  • Avoid's reinstalling flax when generating NNX Basics.
  • Fixes pre-commit errors and a broken test from the recent refactor

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@cgarciae cgarciae force-pushed the nnx-landing-page branch 5 times, most recently from 2160d47 to 499d5e4 Compare August 27, 2024 13:52
@copybara-service copybara-service bot merged commit a0622b0 into main Aug 27, 2024
18 checks passed
@copybara-service copybara-service bot deleted the nnx-landing-page branch August 27, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cgarciae