Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] enable sharding transformation on integer prefixes #4185

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

cgarciae
Copy link
Collaborator

What does this PR do?

Correctly calls spmd.add/remove_axis for integer prefixes on transforms from transforms.iteration (vmap, scan, pmap).

Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@copybara-service copybara-service bot merged commit 1b72435 into main Sep 10, 2024
18 checks passed
@copybara-service copybara-service bot deleted the nnx-transform-metadata-issue branch September 10, 2024 17:11
IvyZX added a commit to IvyZX/flax that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants