Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove notebook exceptions in docs_nnx doctest #4285

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Remove notebook exceptions in docs_nnx doctest #4285

merged 1 commit into from
Oct 16, 2024

Conversation

IvyZX
Copy link
Collaborator

@IvyZX IvyZX commented Oct 10, 2024 •
edited
Loading

  1. Make sure more notebooks are tested by doctest
  2. Make sure to use latest version of jaxlib, jax and orbax-checkpoint in the pip environment

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@IvyZX IvyZX force-pushed the nbunbreak branch 6 times, most recently from 91ce1bd to 87acc93 Compare October 15, 2024 20:59
@copybara-service copybara-service bot merged commit feb399d into google:main Oct 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgarciae cgarciae cgarciae approved these changes

Assignees
No one assigned
Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IvyZX @cgarciae