Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Flax Evolution from Linen to NNX guide #4289

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Update Flax Evolution from Linen to NNX guide #4289

merged 1 commit into from
Oct 21, 2024

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Oct 11, 2024 •
edited
Loading

@8bitmp3 8bitmp3 force-pushed the update-evolution-linen-to-nn branch from 077600b to a3bfb48 Compare October 11, 2024 22:19
@8bitmp3 8bitmp3 marked this pull request as ready for review October 11, 2024 22:19
@8bitmp3 8bitmp3 self-assigned this Oct 11, 2024
@8bitmp3 8bitmp3 force-pushed the update-evolution-linen-to-nn branch 3 times, most recently from e189ab0 to dd0da68 Compare October 11, 2024 23:20
IvyZX
IvyZX approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit more comments this time - some of which are better phrasings that occurred to me when re-reading this piece. Thanks for working on this!

docs_nnx/guides/linen_to_nnx.rst Outdated Show resolved Hide resolved
docs_nnx/guides/linen_to_nnx.rst Outdated Show resolved Hide resolved
docs_nnx/guides/linen_to_nnx.rst Outdated Show resolved Hide resolved
docs_nnx/guides/linen_to_nnx.rst Outdated Show resolved Hide resolved
docs_nnx/guides/linen_to_nnx.rst Outdated Show resolved Hide resolved
docs_nnx/guides/linen_to_nnx.rst Outdated Show resolved Hide resolved
docs_nnx/guides/linen_to_nnx.rst Outdated Show resolved Hide resolved
docs_nnx/guides/linen_to_nnx.rst Outdated Show resolved Hide resolved
docs_nnx/guides/linen_to_nnx.rst Outdated Show resolved Hide resolved
@8bitmp3 8bitmp3 force-pushed the update-evolution-linen-to-nn branch 2 times, most recently from 44430d2 to 244ace3 Compare October 17, 2024 23:24
@8bitmp3 8bitmp3 force-pushed the update-evolution-linen-to-nn branch from 244ace3 to f00917b Compare October 17, 2024 23:46
@copybara-service copybara-service bot merged commit 092ba1d into google:main Oct 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvyZX IvyZX IvyZX approved these changes

@cgarciae cgarciae Awaiting requested review from cgarciae

Assignees

@8bitmp3 8bitmp3

Labels
pull ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8bitmp3 @IvyZX