[nnx] improve mnist tutorial #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cgarciae
force-pushed
the
improve-mnist-tutorial-2
branch
from
e6eae1f
to
b0ee53d
Compare
superbobry
reviewed
Oct 21, 2024
uv.lock
Outdated
superbobry
reviewed
Oct 21, 2024
| @@ -246,6 +246,8 @@ plt.show() | |||
| Create a `jit`-compiled model inference function (with `nnx.jit`) - `pred_step` - to generate predictions on the test set using the learned model parameters. This will enable you to visualize test images alongside their predicted labels for a qualitative assessment of model performance. | |||
|
|
|||
| ```{code-cell} ipython3 | |||
| model.eval() # Switch to evaluation mode. | |||
There was a problem hiding this comment.
Consider explaining a bit more why this is necessary.
There was a problem hiding this comment.
Added an explanation.
superbobry
approved these changes
Oct 21, 2024
cgarciae
force-pushed
the
improve-mnist-tutorial-2
branch
from
b0ee53d
to
d2606ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses
.eval()on inference in the MNIST Tutorial