Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define model surgery in docs #4349

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Oct 30, 2024

@8bitmp3 8bitmp3 self-assigned this Oct 30, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -6,7 +6,7 @@
"source": [
"# Model surgery\n",
"\n",
"In this guide, you will learn how to perform model surgery in Flax NNX using several real-world scenarios:\n",
"Model surgery is an act of performing different tasks on the neural network's building blocks and parameters, such as layer replacement, parameter or state manipulation, or even \"monkey patching\". In this guide, you will learn how to perform model surgery in Flax NNX using several real-world scenarios:\n",
Copy link
Collaborator Author

@8bitmp3 8bitmp3 Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe simpler ?

e.g. "Model surgery is usually referred to as performing "surgery" on your neural network, such as layer replacement, parameter or state manipulation, or even \monkey patching"..."

Suggested change
"Model surgery is an act of performing different tasks on the neural network's building blocks and parameters, such as layer replacement, parameter or state manipulation, or even \"monkey patching\". In this guide, you will learn how to perform model surgery in Flax NNX using several real-world scenarios:\n",
"Model surgery is usually referred to as performing "surgery" on your neural network, such as layer replacement, parameter or state manipulation, or even \"monkey patching\". In this guide, you will learn how to perform model surgery in Flax NNX using several real-world scenarios:\n",

@IvyZX @cgarciae @levskaya LMKWYT

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @IvyZX

"Model surgery is an act of making modifications on an existing neural network's building blocks and parameters, such as layer replacement, parameter or state manipulation, or even "monkey patching"..."

@copybara-service copybara-service bot merged commit b8bdafb into google:main Oct 30, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants