Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modifies the
.update()
to support additional arguments required for the Optaxlbfgs
and related algorithms which rely on linesearch methods.Fixes #4144
lbfgs()
(where I believe the additional arguments are required for thelinesearch
more generally)split
andmerge
in the optimization.model_static, model_state = nnx.split(state.model, self.wrt)
has already been done, themodel_static
can be passed into the.update
to avoid doing thennx.split
step with each iteration. See thetest_jit_linesearch
for more there.A feature missing here is support for
value_and_grad_from_state
as described in https://optax.readthedocs.io/en/stable/_collections/examples/lbfgs.html#linesearches-in-practice. Implementing this would provide some performance advantages as it would allow the optimizer to reuse the gradients/value.