Fix the issue that values of the item decoration is misplaced #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when the user scrolls the RecyclerView. This was because of the reasons that: - FlexboxItemDecoration#isFirstItemInLine wasn't working correctly (it expected the flex lines only being calculated in the FlexboxHelper#calculateFlexLines, not expecting the already calculated flex lines). - In the layoutFlexLine method in FlexboxLayoutManager, calculateItemDecorationsForChild needed to be called before added to the RecyclerView because the view man be created in that method, in that case calcurated decoration's inset values are not set at the time of creation.
|
@yaraki could you have a look? |
|
This should fix #285 |
yaraki
approved these changes
Jun 9, 2017
thagikura
added a commit
that referenced
this pull request
Jun 14, 2017
when the user scrolls the RecyclerView. This was because of the reasons that: - FlexboxItemDecoration#isFirstItemInLine wasn't working correctly (it expected the flex lines only being calculated in the FlexboxHelper#calculateFlexLines, not expecting the already calculated flex lines). - In the layoutFlexLine method in FlexboxLayoutManager, calculateItemDecorationsForChild needed to be called before added to the RecyclerView because the view man be created in that method, in that case calcurated decoration's inset values are not set at the time of creation.
thagikura
added a commit
that referenced
this pull request
Jun 15, 2017
when the user scrolls the RecyclerView. This was because of the reasons that: - FlexboxItemDecoration#isFirstItemInLine wasn't working correctly (it expected the flex lines only being calculated in the FlexboxHelper#calculateFlexLines, not expecting the already calculated flex lines). - In the layoutFlexLine method in FlexboxLayoutManager, calculateItemDecorationsForChild needed to be called before added to the RecyclerView because the view man be created in that method, in that case calcurated decoration's inset values are not set at the time of creation.
thagikura
added a commit
that referenced
this pull request
Jun 16, 2017
when the user scrolls the RecyclerView. This was because of the reasons that: - FlexboxItemDecoration#isFirstItemInLine wasn't working correctly (it expected the flex lines only being calculated in the FlexboxHelper#calculateFlexLines, not expecting the already calculated flex lines). - In the layoutFlexLine method in FlexboxLayoutManager, calculateItemDecorationsForChild needed to be called before added to the RecyclerView because the view man be created in that method, in that case calcurated decoration's inset values are not set at the time of creation.
thagikura
added a commit
that referenced
this pull request
Jun 28, 2017
when the user scrolls the RecyclerView. This was because of the reasons that: - FlexboxItemDecoration#isFirstItemInLine wasn't working correctly (it expected the flex lines only being calculated in the FlexboxHelper#calculateFlexLines, not expecting the already calculated flex lines). - In the layoutFlexLine method in FlexboxLayoutManager, calculateItemDecorationsForChild needed to be called before added to the RecyclerView because the view man be created in that method, in that case calcurated decoration's inset values are not set at the time of creation.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when the user scrolls the RecyclerView.
This was because of the reasons that:
FlexboxItemDecoration#isFirstItemInLine wasn't working correctly (it
expected the flex lines only being calculated in the
FlexboxHelper#calculateFlexLines, not expecting the already calculated
flex lines).
In the layoutFlexLine method in FlexboxLayoutManager,
calculateItemDecorationsForChild needed to be called before added to the
RecyclerView because the view man be created in that method, in that
case calcurated decoration's inset values are not set at the time of
creation.