Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the case where the first view's visibility is gone and the second view is in the second line. #300

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Fixes the case where the first view's visibility is gone and the second view is in the second line. #300

merged 1 commit into from
Jun 14, 2017

Conversation

thagikura
Copy link
Contributor

In that case, the position of the second view is misplaced.

Fixes #283

@thagikura
Fixes the case where the first view's visibility is gone and the second
ed5796c 
view is in the second line.

In that case, the position of the second view is misplaced.

Fixes #283
@thagikura thagikura mentioned this pull request Jun 14, 2017
Closed
@thagikura thagikura requested a review from yaraki June 14, 2017 08:06
yaraki
yaraki approved these changes Jun 14, 2017
View reviewed changes
Copy link
Collaborator

@yaraki yaraki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on 300.

@thagikura
Copy link
Contributor Author

Thanks!

@thagikura thagikura merged commit f93faf9 into dev_recyclerview Jun 14, 2017
@thagikura thagikura deleted the fix_first_view_gone_first_line_single_item branch June 14, 2017 08:49
thagikura added a commit that referenced this pull request Jun 15, 2017
@thagikura
Fixes the case where the first view's visibility is gone and the seco…
376cf5e 
…nd view is in the second line. (#300)

In that case, the position of the second view is misplaced.

Fixes #283
thagikura added a commit that referenced this pull request Jun 16, 2017
@thagikura
Fixes the case where the first view's visibility is gone and the seco…
dbf1909 
…nd view is in the second line. (#300)

In that case, the position of the second view is misplaced.

Fixes #283
thagikura added a commit that referenced this pull request Jun 28, 2017
@thagikura
Fixes the case where the first view's visibility is gone and the seco…
aece313 
…nd view is in the second line. (#300)

In that case, the position of the second view is misplaced.

Fixes #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaraki yaraki yaraki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thagikura @yaraki