Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the issue that the index of the view becomes inconsistent on the #311

Merged
merged 1 commit into from
Jun 19, 2017

Conversation

thagikura
Copy link
Contributor

conditions that

  • Adapter has multiple viewTypes (1, 2. Assuming 2 is the special viewtype)
  • A new item is inserted to the adpater before the view which has the
    special viewType
  • At the time item is inserted, the special view is not visible.

In that case, the index of the view which has the special viewType is
shifted by the number of items inserted before the position.

@thagikura
Copy link
Contributor Author

Fixes #280

conditions that

- Adapter has multiple viewTypes (1, 2. Assuming 2 is the special viewtype)
- A new item is inserted to the adpater before the view which has the
  special viewType
- At the time item is inserted, the special view is not visible.

In that case, the index of the view which has the special viewType is
shifted by the number of items inserted before the position.
@thagikura thagikura requested a review from yaraki June 19, 2017 02:27
@thagikura thagikura merged commit bf1ca87 into dev_recyclerview Jun 19, 2017
@thagikura thagikura mentioned this pull request Jun 19, 2017
@thagikura thagikura added this to the 0.3.0 milestone Jun 19, 2017
@thagikura thagikura deleted the viewtype_incosistency_fix2 branch June 21, 2017 06:47
thagikura added a commit that referenced this pull request Jun 28, 2017
#311)

conditions that

- Adapter has multiple viewTypes (1, 2. Assuming 2 is the special viewtype)
- A new item is inserted to the adpater before the view which has the
  special viewType
- At the time item is inserted, the special view is not visible.

In that case, the index of the view which has the special viewType is
shifted by the number of items inserted before the position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants