Skip to content

RTL indent support #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RTL indent support #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80ea29
Support RTL by using EdgeInsetsDirectional instead of EdgeInsets
ibrahimelaradi Sep 17, 2022
23cb13b
contribution: rtl support on indent
ibrahimelaradi Sep 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
Google Inc.
Abhijeeth Padarthi <rkinabhi@gmail.com>
Alex Li <alexv.525.li@gmail.com>
Ibrahim Elaradi <ibrahimelaradi@gmail.com>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is needed, just going according to the contribution guidelines here, I can remove it if it's needed since the change is trivial

2 changes: 1 addition & 1 deletion packages/flutter_simple_treeview/lib/src/node_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class _NodeWidgetState extends State<NodeWidget> {
),
if (_isExpanded && !_isLeaf)
Padding(
padding: EdgeInsets.only(left: widget.indent!),
padding: EdgeInsetsDirectional.only(start: widget.indent!),
child: buildNodes(widget.treeNode.children!, widget.indent,
widget.state, widget.iconSize),
)
Expand Down