Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[scrollable_positioned_list] Fixed cacheExtent value for horizontal list #453

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[scrollable_positioned_list] Fixed cacheExtent value for horizontal list #453

wants to merge 2 commits into from

Conversation

MAUstaoglu
Copy link

Description

scrollTo does not work on horizontal lists as accurately and efficiently as it does vertical lists. This problem also occurs in horizontal lists because the cacheExtent value is set based on the maximum height. To fix this situation, I fixed the cacheExtent value to be created with maxWidth in horizontal lists.

Related Issues

TODO

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I signed the CLA.
  • All tests from running flutter test pass.
  • flutter analyze does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

tarobins added a commit to tarobins/flutter.widgets that referenced this pull request Apr 26, 2023
@tarobins
[scrollable_positioned_list] Fix default cache extents for horizontal…
e7ca932 
… lists.

Closes google#439 google#453
@tarobins tarobins mentioned this pull request Apr 26, 2023
Merged
tarobins added a commit that referenced this pull request Apr 26, 2023
@tarobins
[scrollable_positioned_list] Fix default cache extents for horizontal (…
573dd42 
…#463)

* [scrollable_positioned_list] Fix default cache extents for horizontal lists.

Closes #439 #453

* Remove unneeded import

* Remove unneeded unwrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MAUstaoglu