Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ScrollOffsetController to current position and scroll without animation #487

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

slawekkrol
Copy link

Description

This PR extends ScrollOffsetController to additional two functions, get current position of scroll and scroll without animation. This is motivated by my own project which I needed move scroll instead of animate (you can't use Duration.zero on scroll animation) conditionally when position >= some item position. To summarize this PR supports both.

Related Issues

#41
#151
#293
#415

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I signed the CLA.
  • All tests from running flutter test pass.
  • flutter analyze does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

@MagTuxGit
Copy link

Could you also add this:
ScrollPosition get position => _scrollableListState!.primary.scrollController.position;
Need to get
scrollOffsetController.position.maxScrollExtent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants