Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Rokkitt v3.103 (stat fix)" #3683

Merged
merged 1 commit into from
Aug 10, 2021
Merged

Revert "Rokkitt v3.103 (stat fix)" #3683

merged 1 commit into from
Aug 10, 2021

Conversation

m4rc1e
Copy link
Collaborator

@m4rc1e m4rc1e commented Aug 10, 2021

Reverts #3663

@m4rc1e m4rc1e merged commit 56db26e into main Aug 10, 2021
@m4rc1e m4rc1e deleted the revert-3663-rokkitt_stat branch August 10, 2021 09:48
@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Aug 10, 2021

@aaronbell apologies, I merged this without inspecting the diffs thoroughly. It appears that #3663 is missing the fl ligature.

glyphs_missing

Can you add this and make another pr?

@aaronbell
Copy link
Collaborator

Will do. I have to say, I have been really frustrated in how, in many cases, the sources don't seem to line up with the current ship font. I guess that's what happens when PRs happen from various different locations?

@m4rc1e
Copy link
Collaborator Author

m4rc1e commented Aug 10, 2021

Can also happen due to changes in the build system and original designers updating the sources.

Tip. Search for the previous PR in this repo to discover the correct source.

@aaronbell
Copy link
Collaborator

Thanks Marc. Yeah, that was the approach I'd used. Clearly wasn't sufficient!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants