Agbalumo: Updated designer name #7151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmamarichal
added
I Article/Description
-- Needs Eng team opinion
|
The non-ascii characters shouldn't cause any problems. I see existing examples of non-ascii characters in use in designer names. |
|
However, do make sure the designer info.pb for this designer is also updated to match the name change. |
|
Excellent, thank you! |
emmamarichal
removed
the
-- Needs Eng team opinion
|
This matches #7174, so LGTM. |
vv-monsalve
approved these changes
Jan 18, 2024
|
There are some issues in Chrome @garretrieger Chrome: Safari |
|
@garretrieger I'm also adding another foundry to the catalog, called Ụdị Foundry, and I wanted to be sure it could be supported (the dotbelow seems to be ok on the ẹ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated Raphael Alegbeleye to Raphael Alẹ́gbẹ́lẹ́yẹ̀ but I'm not sure these accents can be supported.
The doc says Non-ascii characters are supported as UTF-8 but I will need confirmation.
This PR can be closed if it's not supported
@garretrieger