Skip to content

Commit

Permalink
Use the default constructor for NormalizedComponentStorage instead of…
Browse files Browse the repository at this point in the history
… defining one explicitly.

The explicit definition was needed to workaround a bug in old GCC versions, but it's not needed anymore.
  • Loading branch information
poletti-marco committed Mar 26, 2016
1 parent f8cb4bc commit ea234f7
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion include/fruit/impl/storage/normalized_component_storage.h
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class NormalizedComponentStorage {
NormalizedComponentStorage& operator=(NormalizedComponentStorage&&) = default;
NormalizedComponentStorage& operator=(const NormalizedComponentStorage&) = default;

~NormalizedComponentStorage();
~NormalizedComponentStorage() = default;
};

} // namespace impl
Expand Down
5 changes: 0 additions & 5 deletions src/normalized_component_storage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,5 @@ NormalizedComponentStorage::NormalizedComponentStorage(ComponentStorage&& compon
InjectorStorage::addMultibindings(multibindings, fixed_size_allocator_data, std::move(component.multibindings));
}

// TODO: This can't be inline (let alone defined as `=default') with GCC 4.8, while it would work anyway with Clang.
// Consider minimizing the testcase and filing a bug.
NormalizedComponentStorage::~NormalizedComponentStorage() {
}

} // namespace impl
} // namespace fruit

0 comments on commit ea234f7

Please sign in to comment.