Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/fscrypt: make 'fscrypt setup' create /.fscrypt #149

Merged
merged 1 commit into from
Sep 24, 2019
Merged

cmd/fscrypt: make 'fscrypt setup' create /.fscrypt #149

merged 1 commit into from
Sep 24, 2019

Conversation

ebiggers
Copy link
Collaborator

Make the global setup command also create the metadata directory at
/.fscrypt, since that's where login protectors are placed, even when the
actual encrypted directories are on a different filesystem.

Resolves #129

@Maryse47
Copy link

Does it solve #59 as well?

@ebiggers
Copy link
Collaborator Author

Does it solve #59 as well?

No, bind mounts are a separate issue.

Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job fixing this. Thanks for also improving the docs for the fscrypt setup command.

cmd/fscrypt/commands.go Outdated Show resolved Hide resolved
Make the global setup command also create the metadata directory at
/.fscrypt, since that's where login protectors are placed, even when the
actual encrypted directories are on a different filesystem.

Resolves #129
@josephlr josephlr merged commit 6146472 into google:master Sep 24, 2019
@ebiggers ebiggers deleted the setup-root-fs branch September 24, 2019 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fscrypt checks wrong device for setup and throws ErrNotSetup
3 participants