Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare instead of define variable in header file. #224

Merged
merged 1 commit into from
May 10, 2020
Merged

Declare instead of define variable in header file. #224

merged 1 commit into from
May 10, 2020

Conversation

Etrnls
Copy link
Contributor

@Etrnls Etrnls commented May 10, 2020

No description provided.

@ebiggers
Copy link
Collaborator

Thanks, this looks good. I'm guessing you're using gcc 10 (which was just released), and this bug broke the build because gcc 10 defaults to -fno-common? If so, can you mention that in the commit message?

@Etrnls
Declare instead of define variable in header file.
9032044 
This fixes link error with gcc 10 which defaults to -fno-common
@Etrnls
Copy link
Contributor Author

Etrnls commented May 10, 2020

Yes this is to fix build with gcc 10.
Updated commit message.

@ebiggers ebiggers merged commit bd7ebf3 into google:master May 10, 2020
@ebiggers
Copy link
Collaborator

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Etrnls @ebiggers