Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable all shared libs #155

Merged

Conversation

adrianherrera
Copy link
Contributor

Disable shared libs for the other targets. Never used and simplifies builds.

@adrianherrera adrianherrera force-pushed the improvement/dont-build-share-lib branch from bf4def5 to bf67393 Compare August 13, 2019 07:32
@adrianherrera adrianherrera force-pushed the improvement/dont-build-share-lib branch from 71b7ae6 to 3d7956c Compare August 27, 2019 09:36
@adrianherrera adrianherrera deleted the improvement/dont-build-share-lib branch November 25, 2019 13:57
@jonathanmetzman
Copy link
Contributor

Just curious: why did you close this branch?

@adrianherrera adrianherrera restored the improvement/dont-build-share-lib branch November 26, 2019 08:19
@adrianherrera
Copy link
Contributor Author

Ummm good question. By accident!

@adrianherrera adrianherrera reopened this Nov 26, 2019
@EliaGeretto
Copy link

The second commit in this pull request is required also when building boringssl while overriding CFLAGS and CXXFLAGS. The current build script breaks in that case. Maybe it should have gone in a separate pull request? Still, I would like to see it merged.

The justification for it can be found here.

Copy link
Contributor

@morehouse morehouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morehouse morehouse merged commit 7e08b74 into google:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants