Native bridge #1014
Merged
Native bridge #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used for getting the native ABI for NativeBridge emulators.
It's been completely deprecated.
May fix tracing Android applications on Chromebooks where the ABI translator cannot deal with libinterceptor.
tom3q
approved these changes
Aug 29, 2017
pmuetschard
reviewed
Aug 29, 2017
|
|
||
| // NativeBridgeABI returns the native ABI for the given emulated ABI for the | ||
| // device by consulting the ro.dalvik.vm.isa.<emulated_isa>=<native_isa> | ||
| // system properties. |
There was a problem hiding this comment.
I think this should also say that it returns the passed in ABI if there is no emulation.
There was a problem hiding this comment.
never mind... for some reason GH was showing me out of date information and this PR was still open.
There was a problem hiding this comment.
Still a good point. Will fix shortly.
There was a problem hiding this comment.
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
Leaving it selected after destruction was causing a UI exception on macOS. Bug: b/191637172 Test: Manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.