Improve GL error messages #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check only one argument at a time.
ben-clayton
approved these changes
Sep 26, 2017
There was a problem hiding this comment.
Seems like a few of these messages are rather bespoke and could be folded into fewer generic messages that uses a {{name}} parameter.
It would also be nice to actually name the invalid variables / parameters in the messages. I see you've done that for a few of the common errors.
This is a great step in the right direction. I'd like to keep the bug open (or create a new one) that deals with properly naming the each of the invalid parameter / state fields - that said, I'd say this PR is good enough to complete this task for this milestone.
Thank you.
purvisa-at-google-com
added a commit
that referenced
this pull request
Sep 29, 2022
* Add bazel build work for handle remapper codegen * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883