Fix panic due to cancelled context in mesh RPCs. #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
approved these changes
Oct 10, 2017
ben-clayton
force-pushed
the
fix-cancel-panic
branch
from
c24c282 to
80ac5e6
Compare
Use the non-must form to handle context cancellation correctly in hand written code. Fixes google#1123
…rors. These connections can error if the server is shutting down. No need to crash the client.
ben-clayton
force-pushed
the
fix-cancel-panic
branch
from
80ac5e6 to
02a0893
Compare
purvisa-at-google-com
pushed a commit
that referenced
this pull request
Sep 29, 2022
when the application creates an vulkan instance, destroys & creates another instance with the same handle ID. vulkan layer returns VK_ERROR_INITIALIZATION_FAILED as the original instance still exists in the local map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.