-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GAPID gfxtrace file associations #1276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving assuming you've tested windows uninstallation. Thank you
kokoro/windows/gapid.wxs
Outdated
@@ -49,15 +49,39 @@ | |||
<Shortcut Id="ApplicationStartMenuShortcut" Name="GAPID" Description="Graphics API Debugger" | |||
Target="[!gapid.exe]" WorkingDirectory="APPLICATIONROOTDIRECTORY" Icon="gapid.ico" /> | |||
<RemoveFolder Id="CleanUpShortCut" Directory="ApplicationProgramsFolder" On="uninstall" /> | |||
<RegistryValue Root="HKCU" Key="Software\Google\GAPID" Name="installed" Type="integer" Value="1" KeyPath="yes" /> | |||
<RegistryValue Root="HKCU" Key="SOFTWARE\Google\GAPID" Name="installed" Type="integer" Value="1" KeyPath="yes" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an odd change. Completely from memory, isn't "Software" more common? Again, IIRC, the registry is case insensitive, so may not matter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so I changed this to match what I had below and I had it all uppercase below, because the key is actually all upper case in my registry...
However, it appears you are right, convention now is to use "Software", so I've updated it. Yes, the registry keys are case insensitive.
kokoro/windows/gapid.wxs
Outdated
</Component> | ||
</DirectoryRef> | ||
|
||
<Icon Id="gapid.ico" SourceFile="gapid.ico" /> | ||
|
||
<DirectoryRef Id="GAPID"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this automatically delete these keys on uninstallation? I vaguely remember there needing to be some additional attribute for telling WiX that these keys are safe to delete on uninstall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I've tested it and the registry values all get cleaned up on uninstall.
This event is sent on OSX if the user requests GAPID to open a gfxtrace file, for example via double-clicking on a gfxtrace file in the Finder. This event is sent if the application is already running, or if it just has been started in response to opening a file.
Associate .gfxtrace files with GAPID on all platforms:
Fixes #565