Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAPID gfxtrace file associations #1276

Merged
merged 4 commits into from
Oct 30, 2017
Merged

Conversation

pmuetschard
Copy link
Member

Associate .gfxtrace files with GAPID on all platforms:

  • on Windows it is done via the registry, setup by the MSI installer
  • on macOS, GAPIC now listens for the OS event to open the document, and the .app bundle registers GAPID as the owner of gfxtrace files
  • on linux, .deb file now registers a mime type that is associated with GAPID in the .desktop file

Fixes #565

Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming you've tested windows uninstallation. Thank you

@@ -49,15 +49,39 @@
<Shortcut Id="ApplicationStartMenuShortcut" Name="GAPID" Description="Graphics API Debugger"
Target="[!gapid.exe]" WorkingDirectory="APPLICATIONROOTDIRECTORY" Icon="gapid.ico" />
<RemoveFolder Id="CleanUpShortCut" Directory="ApplicationProgramsFolder" On="uninstall" />
<RegistryValue Root="HKCU" Key="Software\Google\GAPID" Name="installed" Type="integer" Value="1" KeyPath="yes" />
<RegistryValue Root="HKCU" Key="SOFTWARE\Google\GAPID" Name="installed" Type="integer" Value="1" KeyPath="yes" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an odd change. Completely from memory, isn't "Software" more common? Again, IIRC, the registry is case insensitive, so may not matter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so I changed this to match what I had below and I had it all uppercase below, because the key is actually all upper case in my registry...

However, it appears you are right, convention now is to use "Software", so I've updated it. Yes, the registry keys are case insensitive.

</Component>
</DirectoryRef>

<Icon Id="gapid.ico" SourceFile="gapid.ico" />

<DirectoryRef Id="GAPID">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this automatically delete these keys on uninstallation? I vaguely remember there needing to be some additional attribute for telling WiX that these keys are safe to delete on uninstall.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've tested it and the registry values all get cleaned up on uninstall.

This event is sent on OSX if the user requests GAPID to open a gfxtrace
file, for example via double-clicking on a gfxtrace file in the Finder.
This event is sent if the application is already running, or if it just
has been started in response to opening a file.
@pmuetschard pmuetschard merged commit 1253fdc into google:master Oct 30, 2017
@pmuetschard pmuetschard deleted the soccer branch October 30, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants