Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tracking the data dependency of destroyed framebuffer images #1657

Merged
merged 3 commits into from
Mar 1, 2018

Conversation

Qining
Copy link
Contributor

@Qining Qining commented Feb 27, 2018

No description provided.

Copy link
Contributor

@AWoloszyn AWoloszyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do this in the api file instead?
I would rather remove them from the LastDrawState on destroy, which will make the api file more correct.

@Qining Qining force-pushed the skip-destroied-frame-image branch from 69afd3f to fde7fe4 Compare February 28, 2018 15:25
@Qining
Copy link
Contributor Author

Qining commented Feb 28, 2018

Updated the api file in 595063b. Also the image views used in descriptor sets are invalidated.

@Qining Qining force-pushed the skip-destroied-frame-image branch from 595063b to 834cc7b Compare February 28, 2018 22:30
@ben-clayton ben-clayton changed the title Skip tracking the data dependency of destroied framebuffer images Skip tracking the data dependency of destroyed framebuffer images Mar 1, 2018
@Qining Qining merged commit 0702cf7 into google:master Mar 1, 2018
@Qining Qining deleted the skip-destroied-frame-image branch October 23, 2018 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants