Compat fixes #1748
Merged
Compat fixes #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuetschard
approved these changes
Mar 15, 2018
gapis/api/gles/compat_buffers.go
Outdated
| // unaligned is a map of compat generated aligned buffer IDs to their | ||
| // original buffer. | ||
| unaligned map[BufferId]*Buffer | ||
| // scratch is a holds the temporary buffers created by the bufferCompat. |
There was a problem hiding this comment.
Good spot. Fixed
We have to jump through hoops to support replaying on targets where the minimum uniform alignment is smaller than the trace target. There was a TODO for handling the case where the buffer is kept bound while the buffer is updated. This CL fixes this case. Issue: google#1563
We only render single-buffered at the moment.
ben-clayton
force-pushed
the
unaligned-bufs
branch
from
bc7cab4 to
20ad88e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.