Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Split the vulkan.api into multiple files #1791

Merged
merged 1 commit into from
Apr 24, 2018

Conversation

Qining
Copy link
Contributor

@Qining Qining commented Apr 12, 2018

Sits on top of #1786 , waits until #1786 is tested and merged.
Sits on top of #1832 . Dependency on #1786 dropped, only trivial structs, bitfields, flags about descriptor update templates are added, no real logic in this CL.

@Qining Qining requested review from AWoloszyn and ben-clayton April 12, 2018 19:10
@Qining Qining changed the title Vulkan: Split the vulkan.api into multiple files WIP: Vulkan: Split the vulkan.api into multiple files Apr 12, 2018
Copy link
Contributor

@AWoloszyn AWoloszyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the dependent is tested/merged this is good to go.

@Qining Qining force-pushed the split-vulkan-api branch 3 times, most recently from 797cffc to ad964c9 Compare April 24, 2018 14:58
@Qining Qining changed the title WIP: Vulkan: Split the vulkan.api into multiple files Vulkan: Split the vulkan.api into multiple files Apr 24, 2018
@Qining Qining force-pushed the split-vulkan-api branch from ad964c9 to c173074 Compare April 24, 2018 18:46
@Qining
Copy link
Contributor Author

Qining commented Apr 24, 2018

All three builds passed before the final rebase, and the final rebase did nothing actually. Merged

@Qining Qining merged commit 796bbe9 into google:master Apr 24, 2018
@Qining Qining deleted the split-vulkan-api branch October 23, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants