Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the threadId when a command is reverted. #1853

Merged
merged 1 commit into from
May 3, 2018

Conversation

pmuetschard
Copy link
Member

The replay builder can revert commands (e.g. due to GL errors). However, the revert was not reverting the command builder's state correctly when the thread changed with the reverted command. Thus, if in BeginCommand it was determined that the thread has changed, a SWITCH_THREAD opcode is prepared, but then reverted, while the command builder would go on, assuming it has switched threads.

The replay builder can revert commands (e.g. due to GL errors).
However, the revert was not reverting the command builder's state
correctly when the thread changed with the reverted command. Thus,
if in BeginCommand it was determined that the thread has changed,
a `SWITCH_THREAD` opcode is prepared, but then reverted, while the
command builder would go on, assuming it has switched threads.
@pmuetschard pmuetschard requested a review from ben-clayton May 2, 2018 23:56
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well found.

@pmuetschard pmuetschard merged commit 6213739 into google:master May 3, 2018
@pmuetschard pmuetschard deleted the threads branch May 3, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants