Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up a bunch of error message in Vulkan. #1948

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

AWoloszyn
Copy link
Contributor

Instead of returning a normal fmt.Errorf(), we now return
a proper service.ErrDataUnavailable. This allow the
UI to show a proper error message unstead of just a
panic in the log view.

Instead of returning a normal fmt.Errorf(), we now return
a proper service.ErrDataUnavailable. This allow the
UI to show a proper error message unstead of just a
panic in the log view.
Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all expected to happen with any given user data?

@AWoloszyn
Copy link
Contributor Author

They are all certainly POSSIBLE with some user data. We don't expect most of them in a correctly written program, but I think we can hit them all normally.

With Qining getting the validation layers together, I am hoping that we can pipe any of the other errors that are "real" errors out more cleanly, and in one spot.

@AWoloszyn AWoloszyn merged commit 6fac734 into google:master Jun 4, 2018
@AWoloszyn AWoloszyn deleted the cleanup-errors branch June 4, 2018 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants