Vulkan: Fix support of sparse buffer #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Support sparse buffer in vkCmdCopyBuffer, vkCmdFillBuffer and vkCmdCopyBufferToImage. 2) Support extract geometry data from sparse buffer 3) 'Read' the memory of sparse buffers 4) Implement doVkCmdFillBuffer
AWoloszyn
reviewed
Jun 12, 2018
| memPieces := getBufferBoundMemoryPiecesInRange(buffer, readOffset, readSize) | ||
| for _, _, mp in memPieces { | ||
| readCoherentMemory(mp.DeviceMemory, mp.MemoryOffset, mp.Size) | ||
| // On the trace side, 'Data' pool won't actually be created, so its length |
There was a problem hiding this comment.
Instead of this way, since data is marked as "spy_disable" can we just not generate the read intrinsic for this case?
We already handle other cases like this, so I think cutting out the read intrinsic for spy_disabled is probably a cleaner approach than a check like this.
AWoloszyn
reviewed
Jun 12, 2018
| dstRange := VkImageSubresourceRange(r.dstSubresource.aspectMask, | ||
| r.dstSubresource.mipLevel, 1, | ||
| r.dstSubresource.baseArrayLayer, r.dstSubresource.layerCount) | ||
| srcRange := VkImageSubresourceRange( r.srcSubresource.aspectMask, |
There was a problem hiding this comment.
Something weird with the spacing here
There was a problem hiding this comment.
wow, looks like the format tool goes crazy.
AWoloszyn
approved these changes
Jun 13, 2018
|
Build passes on all three platforms, tested manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support sparse buffer in vkCmdCopyBuffer, vkCmdFillBuffer and
vkCmdCopyBufferToImage.
Support extract geometry data from sparse buffer
'Read' the memory of sparse buffers
Implement doVkCmdFillBuffer
Tested with all the samples we have.