Vulkan: Reduce the num of cmds for state rebuilding again #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL reduce the number of state rebuild commands of a typical Vulkan application by 70%, and save the `gapit report` time by ~8%. 1) Do not recover the commands in submitted one-time-submit command buffers. 2) Call vkAllocateDescriptorSets for each descriptor pool, instead of each descriptor set. 3) For scratch tasks, when binding and filling the scratch buffers, call vkMapMemory, vkFlushMappedMemoryRanges and vkUnmapMemory only once for the whole task, instead of once for each scratch buffer.
AWoloszyn
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL reduce the number of state rebuild commands of a typical Vulkan
application by 70%, and save the
gapit reporttime by ~8%.Do not recover the commands in submitted one-time-submit command
buffers.
Call vkAllocateDescriptorSets for each descriptor pool, instead of
each descriptor set.
For scratch tasks, when binding and filling the scratch buffers, call
vkMapMemory, vkFlushMappedMemoryRanges and vkUnmapMemory only once for
the whole task, instead of once for each scratch buffer.