A few minor updates to the tracing interface. #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-clayton
approved these changes
Jul 27, 2018
core/os/process/client.go
Outdated
| @@ -29,7 +29,17 @@ import ( | |||
|
|
|||
| var portPattern = regexp.MustCompile(`^Bound on port '(\d+)'$`) | |||
|
|
|||
| type portWatcher struct { | |||
| func NewPortWatcher(portChan chan<- string, | |||
There was a problem hiding this comment.
Nit: No need to break this signature across two lines
core/os/process/client.go
Outdated
| } | ||
| } | ||
|
|
||
| type PortWatcher struct { |
gapis/trace/desktop/trace.go
Outdated
| @@ -144,7 +141,7 @@ func (t *DesktopTracer) GetTraceTargetNode(ctx context.Context, uri string, icon | |||
| children[i] = filepath.Join(uri, children[i]) | |||
There was a problem hiding this comment.
Don't you need to deal with the target device slashes here too?
This allows you to specify environment variables in your ssh config, (instead of having to add them every time). It also exposes portWatcher for external use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to specify environment variables in your
ssh config, (instead of having to add them every time).
It also exposes portWatcher for external use.