Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to GAPID to disable unknown extensions. #2082

Merged
merged 1 commit into from
Jul 25, 2018

Conversation

AWoloszyn
Copy link
Contributor

No description provided.

Copy link
Contributor

@ben-clayton ben-clayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but presubmits are failing.

Copy link
Member

@pmuetschard pmuetschard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java stuff looks good.

What about GLES?

@@ -185,6 +185,8 @@ class SpyBase {
track_memory::MemoryTracker mMemoryTracker;
#endif // TARGET_OS

// This is true if we should not show disabled extensions to the application.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this comment was hard for me to parse :) I think it be better phrased as "If true, we will hide disabled extensions from the application."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@AWoloszyn
Copy link
Contributor Author

@ben-clayton Thanks, I hadn't run the presubmits locally because this was done on my windows machine. I will pull on Linux and fix that.

@AWoloszyn
Copy link
Contributor Author

@pmuetschard According to Ben, GLES doesn't advertise unknown extensions, so this should be a NO-op

I will open a bug to make the option... optional. (Similar to disablePCS)

@AWoloszyn AWoloszyn merged commit 5f65a7b into google:master Jul 25, 2018
@AWoloszyn AWoloszyn deleted the disable-unknown branch July 25, 2018 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants