Add support for rendering during replay to the surface #2112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
reviewed
Jul 31, 2018
| return res; | ||
| } | ||
|
|
||
| device_functions_->vkWaitForFences(device_, 1, &blit_fence_, VK_TRUE, |
There was a problem hiding this comment.
I am a bit leery about this vkWaitForFences. Since this is running on the main thread, we can end up blocking the user thread and synchronizing with the GPU.
|
Odd that presubmit failed here with "Git workspace not clean", not sure what's causing that. Presubmit succeeds locally. |
|
It could be a difference in clang-format versions. |
|
Ah "git workspace not clean" is just the way of saying presubmit changed things? That makes sense |
apazylbe
reviewed
Jul 31, 2018
|
|
||
| // The source image is already in VK_IMAGE_LAYOUT_TRANSFER_SRC, we need to | ||
| // transition our image between VK_IMAGE_LAYOUT_TRANSFER_DST and | ||
| // VK_IMAGE_LAYOUT_SHADER_PRESENT_KHR |
sean-purcell
force-pushed
the
surface-render
branch
from
28a67e0 to
66c9fb5
Compare
It results in more consistent #if's when multiple platforms are supported.
We can't set acquire to 0 here, since the image hasn't necessarily done presenting. This is guaranteed to finish because the only way all base swapchain images could still be in use is if the present hasn't finished yet, but there's nothing blocking those presents.
AWoloszyn
approved these changes
Aug 1, 2018
pmuetschard
added a commit
to pmuetschard/gapid
that referenced
this pull request
Aug 6, 2018
pmuetschard
added a commit
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only Android is supported, but it's easily extensible for other surface types (e.g. Xcb/Win32)
Creating/obtaining the create info for the surface to render to is handled on the gapir side. On the virtual swapchain side, it takes the create info and makes a surface and swapchain, and then when an image is presented to the virtual swapchain it blits to the real swapchain and presents that as well.