Add support for replaying to the surface on Windows and Linux #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-purcell
force-pushed
the
surface-render-win32
branch
from
0c0ce2d to
f236243
Compare
sean-purcell
force-pushed
the
surface-render-win32
branch
from
f236243 to
b6a56e6
Compare
|
Rebased on top of fix from #2125 |
AWoloszyn
reviewed
Aug 3, 2018
| target = gapir::SurfaceType::Android; | ||
| break; | ||
| // These are all linux, so just make an Xcb surface | ||
| case VK_STRUCTURE_TYPE_MIR_SURFACE_CREATE_INFO_KHR: |
There was a problem hiding this comment.
This is not strictly true, but we haven't seen anything that violates this, but technically, if you are on linux you MAY be running a MIR or Wayland compositor where X would fail.
We can handle this if we ever see a system that doesn't allow X.
There was a problem hiding this comment.
Ah ok, yeah if it's an issue adding more window types in the future shouldn't be challenging.
AWoloszyn
approved these changes
Aug 3, 2018
|
I will merge when the builds go green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.