Add Dense map to the API language. #2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qining
approved these changes
Aug 30, 2018
This allows us to create maps that exist in the 0->n where n is small. This provides some performance boost. TODO: Make the same optimization on the Golang side, this should provide better performance there too. This reduces trace overhead by ~10% for a particularly heavy vulkan application.
ben-clayton
reviewed
Sep 10, 2018
|
|
||
| template<typename T, bool DENSE> | ||
| typename std::enable_if<!std::is_integral<T>::value, uint64_t>::type dense_hash(const T& t) { | ||
| return 0; |
There was a problem hiding this comment.
Can we delete this implementation so that it won't compile if the key is non-integral (that or put some statement in here that doesn't compile with a comment)? Doesn't seem like you'd ever want this to compile...
There was a problem hiding this comment.
We can once
// TODO(awoloszyn): Template tricks to move this to compile-time
is resolved. Until then we have a dynamic check, which means this will need to compile.
ben-clayton
added a commit
to ben-clayton/gapid
that referenced
this pull request
Sep 11, 2018
Broken by google#2173
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to create maps that exist in the 0->n where
n is small. This provides some performance boost.
TODO: Make the same optimization on the Golang side, this should
provide better performance there too.
This reduces trace overhead by ~10% for a particularly heavy
vulkan application.