Pre-resolve dependency graph #2181
Conversation
| @@ -230,6 +233,14 @@ func (s *server) LoadCapture(ctx context.Context, path string) (*path.Capture, e | |||
| if _, err = capture.ResolveFromPath(ctx, p); err != nil { | |||
| return nil, err | |||
| } | |||
| // Pre-resolve the dependency graph. | |||
There was a problem hiding this comment.
@AWoloszyn I'm not sure if this is a proper place to insert the code. This makes the function name: 'LoadCapture' not that accurate. If so, we also need to do the same for 'ImportCapture'.
Another place is the capture.go:Import(), just after the path.Capture is built. Then we will need to resolve the capture there first, then resolve dependency graph.
Any suggestions?
There was a problem hiding this comment.
Are you using new context here because the context passed to LoadCapture is cancelled by gRPC? I'm not making any sort of judgement here - just curious.
As for your question - I think the most sensible place to pre-resolve would be at the end of capture.builder.build, but I'm fairly certain that you can't, as that would form a cyclic dependency between capture and dependencygraph. This seems reasonable for now.
There was a problem hiding this comment.
Yes exactly.
Cool, so I will just preresolve the graph here.
| @@ -230,6 +233,14 @@ func (s *server) LoadCapture(ctx context.Context, path string) (*path.Capture, e | |||
| if _, err = capture.ResolveFromPath(ctx, p); err != nil { | |||
| return nil, err | |||
| } | |||
| // Pre-resolve the dependency graph. | |||
There was a problem hiding this comment.
Are you using new context here because the context passed to LoadCapture is cancelled by gRPC? I'm not making any sort of judgement here - just curious.
As for your question - I think the most sensible place to pre-resolve would be at the end of capture.builder.build, but I'm fairly certain that you can't, as that would form a cyclic dependency between capture and dependencygraph. This seems reasonable for now.
Resolve the dependency graph in parallel immediately once the capture data is resolve. This speed up the GAPIS side a bit (~30 sec for a typical Vulkan app, 1.8G trace file) for buliding the instructions to get the framebuffer data from the replay device.
Qining
force-pushed
the
pre-resolve-footprint
branch
from
ffc9356 to
d182024
Compare
Resolve the dependency graph in parallel immediately once the capture
data is resolve. This speed up the GAPIS side a bit (~30 sec for a
typical Vulkan app, 1.8G trace file) for buliding the instructions to
get the framebuffer data from the replay device.
based on #2172