Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how we handle descriptor sets again. #2204

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

AWoloszyn
Copy link
Contributor

This provides some performance benefit.

@AWoloszyn AWoloszyn requested a review from Qining September 12, 2018 19:38
newOffsets := descriptors.bufferOffsets
for _, j, jj in offsets {
for _, k, v in jj {
newOffsets[j][k][v] = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, multi-layer maps need special care

This provides some performance benefit.
@AWoloszyn AWoloszyn merged commit 9a70b28 into google:master Sep 14, 2018
@AWoloszyn AWoloszyn deleted the update_descriptors branch September 14, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants