Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Smarter check for temporary shader modules, renderpasses etc. #2235

Merged

Conversation

Qining
Copy link
Contributor

@Qining Qining commented Sep 19, 2018

When rebuilding the initial commands for pipelines, there might be
shader modules and renderpasses with the same handle value as the ones in
pipelines, but actually means different content. For such cases, we
should also create temporary shader modules and renderpasses

When rebuilding the initial commands for pipelines, there might be
shader modules and renderpasses with the same handle value as the ones in
pipelines, but actually means different content. For such cases, we
should also create temporary shader modules and renderpasses
Copy link
Contributor

@AWoloszyn AWoloszyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all of the temporaries in our state reconstruction or are there more? (I.e. should we be making this fix in more places)

@Qining Qining merged commit 68bd24a into google:master Sep 20, 2018
@Qining Qining deleted the temporary-shader-renderpass-pipelinelayout branch October 23, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants