Linux: Be more aggressive about keeping the memory tracker on. #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qining
reviewed
Sep 25, 2018
| bool IsInstalled() const { return signal_handler_registered_; } | ||
| bool IsInstalled() const { | ||
| struct sigaction orig_action { | ||
| 0 |
There was a problem hiding this comment.
Nit: does clang-format allow us to make it one line?
There was a problem hiding this comment.
I think it does if you change this to sigaction orig_action = {0}.
Qining
approved these changes
Sep 25, 2018
AWoloszyn
force-pushed
the
memory_tracker
branch
from
9c87c71 to
baee314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.