Vulkan: Sampler_ycbcr_conversion step 2 #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
approved these changes
Jan 17, 2019
Add helper function: getAspectKeysFromAspectFlags(), given an aspect mask flag, returns a list of aspect bit keys, which can be used in indexing image->aspect->layer->level hierarchy and also the potential separated memory binding info hierarchy. Index the memory requirements by aspect(plane) bits Add helper function: getImagePlaneMemoryRequirments() to manage getting image plane memory requirements. All uses of image requirements should get the requirement info from this helper function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2534 and #2531
Add helper function:
getAspectKeysFromAspectFlags(), given an aspectmask flag, returns a list of aspect bit keys, which can be used in
indexing image->aspect->layer->level hierarchy and also the potential
separated memory binding info hierarchy.
Index the memory requirements by aspect(plane) bits
Add helper function:
getImagePlaneMemoryRequirments()to manage gettingimage plane memory requirements. All uses of image requirements should
get the requirement info from this helper function.