Get Robot building and working again. #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pau-baiget
reviewed
Feb 11, 2019
pau-baiget
approved these changes
Feb 11, 2019
ben-clayton
approved these changes
Feb 11, 2019
|
Other than style nits, the only thing I want to comment on is that I think how we package up OBB files for Robot will have changed. Now it is expected that you EITHER pass a .apk file down in this call OR a zip file that contains your your .apk + .obb files. This way everything can be in a single file. |
It's nil and causes a panic.
Return the host's binaries in case the ABI is nil.
The error cannot possibly be non-nil at that point.
If given a URI of the form `apk:<file>` it will send the APK to the gapis to be installed on the device and traced.
This is how it used to work for automated scripts.
This way the tracing logic for an newly installed app will "just work" as if the URI had been specified in the request.
|
re: obb - if put in a TODO and made robot return an error if a subject with an OBB is attempted to be traced. If we actually want OBBs again we can fix robot to properly package them, or fix gapit to do it for robot. |
AWoloszyn
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.