-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gapid2apk] add standalone APK creation to export_replay #2621
Conversation
Please ensure you squash these changes before submitting. Given that nobody has started reviewing yet, perhaps now would be a good time to squash to one or a few CLs?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good so far. Good stuff!
FYI: This may be a future update, but I tried this, and the performance was rather abysmal. From what I could tell, almost all of the time was spend unzipping resources from the archive. (Which is somewhat expected). |
130cf07
to
e9385e6
Compare
1434b2f
to
366e9cc
Compare
Thanks for the previous review, I tried to fix all remarks. This PR enables to create a stand-alone APK which replay a given trace. We are still facing issues when trying to trace the created APKs, but we can fix these issues later. As it is a big change, we may think of splitting this in a few PRs, feel free to suggest such splitting. |
Other than the comments from @pmuetschard it looks good to me. |
The APK is created from the regular GAPID APK by addind replay export files as assets, and GAPIR detects those files and replay from them.
Many thanks Pascal for the detailed feedback! |
The OSX build fails with |
This is all the code needed for gapid2apk on the gapir side: detect replay resources in the apk assets, and if present use them to do the replay.
The missing part is the external command to actually create a new APK with replay resources: I have this implemented as a bash script, but we will want it as a regular command in Go for the sake or portability.
I open the PR now for reviews of the GAPIR side of things, and I will add the APK creation command soon.