Correctly set the target/min SDK API. #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sigh. For the NDK rule, the API level is really the minimum API level, since that's what will be linked against, while for the SDK, it's the target API. Our native code requires API level 21 (5.0 Lollipop), so updated the manifests as well. Fixes google#2389
AWoloszyn
reviewed
Mar 1, 2019
| @@ -199,14 +199,14 @@ def gapid_dependencies(android = True, mingw = True, locals = {}): | |||
| native.android_sdk_repository, | |||
| name = "androidsdk", | |||
| locals = locals, | |||
| api_level = 26, | |||
| api_level = 26, # This is the target API | |||
There was a problem hiding this comment.
These are delightfully consistent with each other :\
AWoloszyn
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sigh. For the NDK rule, the API level is really the minimum API level, since that's what will be linked against, while for the SDK, it's the target API. Our native code requires API level 21 (5.0 Lollipop), so updated the manifests as well.
Fixes #2389