Add VK_KHR_draw_indirect_count extensions. #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWoloszyn
force-pushed
the
VK_KHR_draw_indirect_count
branch
2 times, most recently
from
a0c1d60 to
958f567
Compare
pmuetschard
approved these changes
Mar 7, 2019
| return nil, nil, fmt.Errorf("Cannot find Buffer %v", d.Buffer()) | ||
| } | ||
| if !GetState(s).Buffers().Contains(d.CountBuffer()) { | ||
| return nil, nil, fmt.Errorf("Cannot find Buffer %v", d.Buffer()) |
There was a problem hiding this comment.
It might be helpful to say "Count Buffer" here and in each of the other functions, so that it's more clear which argument the error is for.
gapis/api/vulkan/vulkan.api
Outdated
| @@ -227,6 +229,9 @@ sub ref!ExtensionSet supportedDeviceExtensions() { | |||
| supported.ExtensionNames["VK_KHR_maintenance1"] = true | |||
| supported.ExtensionNames["VK_KHR_maintenance2"] = true | |||
| supported.ExtensionNames["VK_KHR_maintenance3"] = true | |||
| supported.ExtensionNames["VK_KHR_maintenance3"] = true | |||
There was a problem hiding this comment.
This one is extra and duplicates the previous line.
|
|
||
| sub void dovkCmdDrawIndirectCountCOMMON!T(T draw) { | ||
| useRenderPass() | ||
| if draw.MaxDrawCount > 0 { |
There was a problem hiding this comment.
nit: Everywhere this sub is called, it's already guarded with this check. Could make it a precondition of this sub - I think a comment would do.
Same for dovkCmdDrawIndexedIndirectCountCOMMON
Qining
approved these changes
Mar 7, 2019
This also adds VK_AMD_draw_indirect_count which is the same.
AWoloszyn
force-pushed
the
VK_KHR_draw_indirect_count
branch
from
958f567 to
94f99e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds VK_AMD_draw_indirect_count which is the same.