Guard invalid device memory flushes. #2671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuetschard
approved these changes
Mar 13, 2019
pau-baiget
reviewed
Mar 14, 2019
| @@ -211,7 +211,7 @@ cmd VkResult vkFlushMappedMemoryRanges( | |||
| } | |||
| } | |||
|
|
|||
| if !(flushRange.memory in DeviceMemories) { vkErrorInvalidDeviceMemory(flushRange.memory) } | |||
| if !(flushRange.memory in DeviceMemories) { vkErrorInvalidDeviceMemory(flushRange.memory) } else { | |||
There was a problem hiding this comment.
Is there a reason for not bothering indenting this block of code?
Side comment: I don't like inline if statements, however I won't push new styles if it's the standard for these .api source files.
There was a problem hiding this comment.
So the reason that we have been doing this is because we can't early-return in the API language.
We use this pattern so that we don't add incredible amounts of nesting.
What I REALLY want to say is
if !(flush.memory in DeviceMemories) { return; }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2617.