Use the new system settings driven layer system to trace. #2700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuetschard
force-pushed
the
prop_layers
branch
2 times, most recently
from
050dcee to
2857b50
Compare
AWoloszyn
approved these changes
Apr 2, 2019
For Android, query the EGL extensions both with and without a display and report them in the list of GL extensions.
For GLES, if layers are supported, no longer use JDWP and libinterceptor to trace, but the layers instead. For Vulkan use the system settings to setup the layer, rather than the global system property and skip the JDWP interception to modify the classpath. Since we no longer require JDWP when using the new layers, we will no longer require apps to be marked debuggable on non-rooted device and tracing will work on apps marked profilable.
When querying the device info for Android when tracing there was a deadlock, due to EGL functions calling EGL functions and EGL functions automatically being called at thread exit. This caused a deadlock when this happened in response to querying the device info while creating the spy. This change avoids this by properly unbinding the context before destroying it and calling eglReleaseThread ourselves.
Instead of after getting the spy, since (only the first time) getting the spy has side effects.
pmuetschard
added a commit
to pmuetschard/gapid
that referenced
this pull request
Apr 8, 2019
When using the layer settings to trace, don't also set the global layer property. This is something that should have been part of google#2700, but must have been lost in one of the merges/rebases.
pmuetschard
added a commit
to pmuetschard/gapid
that referenced
this pull request
Apr 8, 2019
When using the layer settings to trace, don't also set the global layer property. This is something that should have been part of google#2700, but must have been lost in one of the merges/rebases.
pmuetschard
added a commit
that referenced
this pull request
Apr 9, 2019
When using the layer settings to trace, don't also set the global layer property. This is something that should have been part of #2700, but must have been lost in one of the merges/rebases.
pmuetschard
added a commit
to pmuetschard/gapid
that referenced
this pull request
Apr 9, 2019
When using the layer settings to trace, don't also set the global layer property. This is something that should have been part of google#2700, but must have been lost in one of the merges/rebases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For GLES, if layers are supported, no longer use JDWP and libinterceptor to trace, but the layers instead.
For Vulkan use the system settings to setup the layer, rather than the global system property and skip the JDWP interception to modify the classpath.
Since we no longer require JDWP when using the new layers, we will no longer require apps to be marked debuggable on non-rooted device and tracing will work on apps marked profilable.