Add GVR support #982
Merged
Add GVR support #982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds in a new @abi_type annotation to specify a different type to use when passing the type as an exported variable. This is needed as structs appear to behave differently when passed with and without a copy constructor.
Groups GVR frames. Yay!
Was a hack for GVR. Now fixed.
Needs special love as the framebuffer is unbound at this point.
Use these commands to help populate GVR frame -> gles framebuffers.
AWoloszyn
reviewed
Aug 24, 2017
| @@ -185,8 +188,12 @@ Spy::Spy() | |||
| mCaptureFrames = header.mNumFrames; | |||
| mSuspendCaptureFrames.store((header.mFlags & ConnectionHeader::FLAG_DEFER_START)? | |||
| kSuspendIndefinitely: mSuspendCaptureFrames.load()); | |||
| if (header.mGvrHandle != 0) { | |||
There was a problem hiding this comment.
If I understand correctly we get the GVR handle from JDWP, then send it back to the application later in the connection header.
That feel .. painful, but I understand why we do it this way.
There was a problem hiding this comment.
yup. All because it's near impossible to obtain the android.context.Context from JNI, which is needed to call the GVR loader to get the GVR handle. 😞
AWoloszyn
approved these changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.