Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

GCM for IOS: Bitcode #91

Closed
Ruud-cb opened this issue Aug 27, 2015 · 67 comments
Closed

GCM for IOS: Bitcode #91

Ruud-cb opened this issue Aug 27, 2015 · 67 comments

Comments

@Ruud-cb
Copy link

Ruud-cb commented Aug 27, 2015

New Apple standards recommend apps to have Bitcode enabled, GCM doesn't support Bitcode yet. Updated pods today to GCM 1.0.3. Got error when building for IOS device or archive:

d: '/PathToApp/Pods/Google/Libraries/libGGLCloudMessaging.a(GGLContext+CloudMessaging.o)' 
does not contain bitcode. 
You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), 
obtain an updated library from the vendor, or disable bitcode for this target. 
for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
@silvolu
Copy link
Contributor

silvolu commented Aug 27, 2015

@ruud thanks for your feedback! We will add it in the next release.

@amyleecodes
Copy link

Seconding this, as we're now trying to ship iOS 9 versions of our apps since the GM SDK is available. GCM (and dependencies) are stopping us from uploading bitcode versions of apps.

@Ruud-cb
Copy link
Author

Ruud-cb commented Sep 10, 2015

Just a side question, will it prevent me from publishing new apps? e.g. rejection on app submission?

@silvolu
Copy link
Contributor

silvolu commented Sep 10, 2015

According to Apple, "For iOS apps, bitcode is the default, but optional. If you provide bitcode, all apps and frameworks in the app bundle need to include bitcode. For watchOS apps, bitcode is required." So unless you are submitting with watchOS, you should be fine.

@amyleecodes
Copy link

Definitely optional, but it's important to support. Being able to slim a giant app down in size is going to be a HUGE boost for downloads, and can be the difference between staying under the cellular limit and not.

@tapz
Copy link

tapz commented Sep 28, 2015

When are new versions of the binaries coming out? I has been a month since this issues was created and still no new binaries. It's just one compiler flag.

@blixt
Copy link

blixt commented Nov 14, 2015

This is still an issue:

ld: '.../Pods/GoogleUtilities/Libraries/libGTM_NSData+zlib.a(GTMNSData+zlib.o)' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. for architecture armv7

This issue has been around for almost four months now. When is the next version coming out?

@mohitsharma0690
Copy link

It's not as simple as flipping a flag for us. Having said that we know this is a priority request and we are trying our best to get it in as soon as possible.

@anhletuan
Copy link

I have the same problem. This issue hasn't been fixed :(.

@domhof
Copy link

domhof commented Dec 18, 2015

Same problem here! When is the next version coming out?

@coolnalu
Copy link

Just ran into this issue as well.

@fulldecent
Copy link

This issue is just a subset of the more important issue:

We need this to be open source or else there will frequently be late nights where our release is held hostage to Google fixing an issue


Even with the best intentions, Google has clearly demonstrated that closed source software is incompatible with peace of mind for iOS software development.

@fulldecent
Copy link

FYI, for anyone that is up at 5am and is committed to shipping product before you go to bed, here is the "f*ck you, just make it work, I need to sleep" solution.

screen shot 2015-12-20 at 3 23 40 am

@danielmlozano
Copy link

HAHAHA that solution saved my ass. Thanks a lot!

@elloboblanco
Copy link

Thanks @fulldecent !

@philippeluickx
Copy link

+1

@JuanjoArreola
Copy link

It would be nice to support bitcode, just saying.

@gask
Copy link

gask commented Jan 12, 2016

GCM needs to support bitcode urgently.
It's an absurdity it's been like this for 6 months.

@asafam
Copy link

asafam commented Jan 12, 2016

+1

@danieltamiosso
Copy link

Any news?

@silvolu
Copy link
Contributor

silvolu commented Jan 14, 2016

So, our problem here is that we depend on changes to our toolchain that we don't directly control.
We should be quite near the end of the work that enables us compile with bitcode enabled, but I don't have any specific dates to share unfortunately.

@ericb
Copy link

ericb commented Jan 15, 2016

@silvolu Thanks for the update. Is there anything the community can do to help, or is this an internal toolchain?

edit: Oops, missed your clarification in the comment.

@kiroskirin
Copy link

Any update on bitcode error from /Pods/GoogleUtilities/Libraries/libGTM_NSData+zlib.a(GTMNSData+zlib.o) ?

@dincho
Copy link

dincho commented Jan 25, 2016

AGRH! Google! YOU AGAIN!

@mikkokut
Copy link

+1

@smaspe
Copy link

smaspe commented Jan 28, 2016

+1. This libGTM_NSData+zlib is included in the Google/Analytics pod, which sucks.

@weirany
Copy link

weirany commented Jan 29, 2016

+1

@naeem
Copy link

naeem commented Feb 9, 2016

+1

@CisSovereign
Copy link

+1 Still an issue. May not use this going forward because of this issue.

@mohitsharma0690
Copy link

We're very close to adding Bitcode in GCM and will most likely release a new lib version with it in a week or so. We're also actively working on enabling Bitcode in all of GCM's internal deps but that might take a bit more time another week or so.

Rest assured this is one of the priorities and we're very close to having this shipped with full bitcode support.

@ghost
Copy link

ghost commented Feb 10, 2016

+1

3 similar comments
@oussamaFirespotter
Copy link

+1

@mauropiccini
Copy link

+1

@DenisDorokhov
Copy link

+1

@pronebird
Copy link

GoogleAnalytics is very different from Google/Analytics and seem to be missing some headers and files.

@afshin-hoseini
Copy link

@fulldecent +1

@amit-bst
Copy link

+1

5 similar comments
@mt404
Copy link

mt404 commented Feb 18, 2016

+1

@mertnesvat
Copy link

+1

@nikolajerry1993
Copy link

+1

@iantheparker
Copy link

+1

@brainloops
Copy link

+1

@Ruud-cb
Copy link
Author

Ruud-cb commented Feb 19, 2016

All those +1 almost feels like spam, any updates @silvolu ?

@silvolu
Copy link
Contributor

silvolu commented Feb 19, 2016

@Ruud-cb sorry, work still in progress. We're near, but still cannot give you a timeframe I'm 100% confident about.

@Ruud-cb
Copy link
Author

Ruud-cb commented Feb 19, 2016

@silvolu Alright thanks for the update! A 50% - 99% estimate is welcome :). Are we talking about weeks, months.. years? Of course the earliest the best for everyone, but personally I would like to know if I can expect this to be "bitecode friendly" in the next 2 - 4 months.

@aried3r
Copy link

aried3r commented Feb 19, 2016

If the +1s keep coming, could this issue be locked and regularly be
updated? I'd much rather have updates, even if negative, than constant
emails about +1s.

On Fri, Feb 19, 2016, 18:43 Ruud notifications@github.com wrote:

@silvolu https://github.com/silvolu Alright thanks for the update! A
50% - 99% estimate is welcome :). Are we talking about weeks, months..
years? Of course the earliest the best for everyone, but personally I would
like to know if I can expect this to be "bitecode friendly" in the next 2 -
4 months.


Reply to this email directly or view it on GitHub
#91 (comment).

@silvolu
Copy link
Contributor

silvolu commented Feb 19, 2016

@Ruud-cb a matter of weeks :)

@hjanuschka
Copy link

+1

@google google locked and limited conversation to collaborators Feb 19, 2016
@silvolu
Copy link
Contributor

silvolu commented Apr 20, 2016

This should be fixed now.

@google google unlocked this conversation Apr 20, 2016
@mt404
Copy link

mt404 commented Apr 20, 2016

Yes!

@silvolu
Copy link
Contributor

silvolu commented Apr 20, 2016

And I spoke too soon, sorry. Almost there.

@google google locked and limited conversation to collaborators Apr 20, 2016
@mohitsharma0690
Copy link

Should be fixed now. Please reopen if you see any issues.

Also please test with the latest version.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests